Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ?
| От | Thomas Munro |
|---|---|
| Тема | Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ? |
| Дата | |
| Msg-id | CA+hUKGLY=p4D=iW1TRVTK=cY3AOhFV3B--HMZHbjL6GypoT8+Q@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ? (Peter Smith <smithpb2250@gmail.com>) |
| Ответы |
Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ?
Re: replication cleanup code incorrect way to use of HTAB HASH_REMOVE ? |
| Список | pgsql-hackers |
On Mon, Mar 22, 2021 at 10:50 AM Peter Smith <smithpb2250@gmail.com> wrote: > The real problem isn't the Assert. It's all those other usages of ent > disobeying the API rule: "(NB: in the case of the REMOVE action, the > result is a dangling pointer that shouldn't be dereferenced!)" I suppose the HASH_REMOVE case could clobber the object with 0x7f if CLOBBER_FREED_MEMORY is defined (typically assertion builds), or alternatively return some other non-NULL but poisoned pointer, so that problems of this ilk blow up in early testing.
В списке pgsql-hackers по дате отправления: