Re: Streaming I/O, vectored I/O (WIP)

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: Streaming I/O, vectored I/O (WIP)
Дата
Msg-id CA+hUKGLJi+c5jB3j6UvkgMYHky-qu+LPCsiNahUGSa5Z4DvyVA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Streaming I/O, vectored I/O (WIP)  (Dilip Kumar <dilipbalaut@gmail.com>)
Ответы Re: Streaming I/O, vectored I/O (WIP)
Re: Streaming I/O, vectored I/O (WIP)
Список pgsql-hackers
On Tue, Mar 12, 2024 at 11:39 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> + actual_nblocks = operation->nblocks = *nblocks = i + 1;
> (Dilip: I think we should break after this?)

In the next loop, i < actual_nblocks is false so the loop terminates.
But yeah that was a bit obscure, so I have added an explicit break.

Here also is a new version also of the streaming_read.c patch.  This
is based on feedback from the bitmap heap scan thread, where Tomas and
Melanie noticed some problems when comparing effective_io_concurrency
= 0 and 1 against master.  The attached random.sql exercises a bunch
of random scans with different settings, and random.txt shows the
resulting system calls, unpatched vs patched.  Looking at it that way,
I was able to tweak the coding until I had the same behaviour as
master, except with fewer system calls wherever possible due to
coalescing or suppressing sequential advice.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Make attstattarget nullable
Следующее
От: Aleksander Alekseev
Дата:
Сообщение: Re: [PATCHES] Post-special page storage TDE support