Re: [Patch] Add a reset_computed_values function in pg_stat_statements

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: [Patch] Add a reset_computed_values function in pg_stat_statements
Дата
Msg-id CA+hUKGKyHm3Hip7j=m_s8csAQb3uK70DzO8cemT3U+Eu0L7dBw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [Patch] Add a reset_computed_values function inpg_stat_statements  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Ответы Re: [Patch] Add a reset_computed_values function inpg_stat_statements
Список pgsql-hackers
On Thu, Sep 26, 2019 at 8:05 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> This patch seems to be failing the contrib build.  Please fix.

Hi Pierre,

In contrib/pg_stat_statements/pg_stat_statements.c, you need to
declare or define entry_reset_computed() before you use it.  I suppose
your compiler must be warning about that.  I personally put
"COPT=-Wall -Werror" into src/Makefile.custom to make sure that I
don't miss any warnings.  That's also what http://cfbot.cputube.org/
does (a thing that does a full check-world on all registered patches
to look for such problems).



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: patch: psql - enforce constant width of last column
Следующее
От: Thomas Munro
Дата:
Сообщение: Re: Collation versioning