Re: Refactoring the checkpointer's fsync request queue

On Thu, Apr 4, 2019 at 5:36 PM Andres Freund <andres@anarazel.de> wrote:
> On 2019-04-03 21:19:45 -0700, Shawn Debnath wrote:
> > +typedef struct FileTag
> > +{
> > +     int16           handler;                /* SyncRequstHandler value, saving space */
> > +     int16           forknum;                /* ForkNumber, saving space */
> > +     RelFileNode rnode;
> > +     BlockNumber segno;
> > +} FileTag;
>
> Seems odd to me to use BlockNumber for segno.

That is a tradition in md.c code.  I had a new typedef SegmentNumber
in all sync.{c,h} stuff in an earlier version, but had trouble
figuring out where to define it...

-- 
Thomas Munro
https://enterprisedb.com