Re: FileFallocate misbehaving on XFS

On Sat, Dec 14, 2024 at 9:29 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2024-Dec-11, Andres Freund wrote:
> > One thing that I think we should definitely do is to include more detail in
> > the error message. mdzeroextend()'s error messages don't include how many
> > blocks the relation was to be extended by. Neither mdextend() nor
> > mdzeroextend() include the offset at which the extension failed.
>
> I proposed a patch at
> https://postgr.es/m/202409110955.6njbwzm4ocus@alvherre.pgsql

If adding more logging, I wonder why FileAccess()'s "re-open failed"
case is not considered newsworthy.  I've suspected it as a candidate
source of an unexplained and possibly misattributed error in other
cases.  I'm not saying it's at all likely in this case, but it seems
like just the sort of rare unexpected failure that we'd want to know
more about when trying to solve mysteries.