On Sat, Jul 8, 2023 at 8:52 AM Tristan Partin <tristan@neon.tech> wrote:
> Should you wrap the two _l function replacements in HAVE_USELOCALE
> instead of WIN32?
I find that more confusing, and I'm also not sure if HAVE_USELOCALE is
even going to survive (based on your nearby thread). I mean, by the
usual criteria that we applied to a lot of other system library
functions in the 16 cycle, I'd drop it. It's in the standard and all
relevant systems have it except Windows which we have to handle with
special pain-in-the-neck logic anyway.
> > +if not cc.has_type('locale_t', prefix: '#include <locale.h>') and cc.has_type('locale_t', prefix: '#include
<xlocale.h>')
>
> I wouldn't mind a line break after the 'and'.
Ah, right, I am still learning what is allowed in this syntax... will do.
> Other than these comments, the patch looks fine to me.
Thanks. I will wait a bit to see if Peter has any other comments and
then push this. I haven't actually tested with Solution.pm due to
lack of CI for that, but fingers crossed, since the build systems will
now agree, reducing the screw-up surface.