Re: md.c vs elog.c vs smgrreleaseall() in barrier

On Thu, Mar 20, 2025 at 12:06 PM Andres Freund <andres@anarazel.de> wrote:
> Ah - it effectively is already in a critical section, just a weirdly spelled one:
>
> 2025-03-19 19:00:06.398 EDT [2156613][client backend][0/3:0][psql] LOG:  statement: DROP TABLE foo;
> 2025-03-19 19:00:06.404 EDT [2156613][client backend][0/0:43139][psql] ERROR:  muahahaha
> 2025-03-19 19:00:06.404 EDT [2156613][client backend][0/0:43139][psql] STATEMENT:  DROP TABLE foo;
> 2025-03-19 19:00:06.404 EDT [2156613][client backend][0/0:43139][psql] WARNING:  AbortTransaction while in COMMIT
state
> 2025-03-19 19:00:06.404 EDT [2156613][client backend][0/0:43139][psql] PANIC:  cannot abort transaction 43139, it was
alreadycommitted 
>
> Obviously not great, but better than corruption.

Yeah, I called that a crypto-critical-section over in this thread:

https://www.postgresql.org/message-id/flat/ZYw8gVOMF9gfp6i5%40pryzbyj2023