On Wed, 26 Feb 2020 at 11:33, yuzuko <yuzukohosoya@gmail.com> wrote:
>
> Hi,
>
> Thanks for reviewing the patch.
>
> > > We can make it work correctly but I think perhaps we can skip updating
> > > statistics values of partitioned tables other than n_mod_since_analyze
> > > as the first step. Because if we support also n_live_tup and
> > > n_dead_tup, user might get confused that other statistics values such
> > > as seq_scan, seq_tup_read however are not supported.
> >
> > +1, that makes sense.
> >
> Yes, Indeed. I modified it not to update statistics other than
> n_mod_since_analyze.
> Attach the v5 patch. In this patch, pgstat_report_analyze() always reports 0 as
> msg.m_live_tuples and m_dead_tuples when the relation is partitioned.
>
Thank you for updating the patch. I'll look at it. I'd recommend to
register this patch to the next commit fest so at not to forget.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services