On Sat, 11 Jan 2020 at 18:52, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> On 2020-01-10 04:32, Masahiko Sawada wrote:
> > I agreed that these patches are useful on its own and 0001 patch and
>
> committed 0001
>
> > 0002 patch look good to me. For 0003 patch,
> >
> > + linkend="guc-primary-slot-name"/>. Otherwise, the WAL receiver may use
> > + a temporary replication slot (determined by <xref
> > + linkend="guc-wal-receiver-create-temp-slot"/>), but these are not shown
> > + here.
> >
> > I think it's better to show the temporary slot name on
> > pg_stat_wal_receiver view. Otherwise user would have no idea about
> > what wal receiver is using the temporary slot.
>
> Makes sense. It makes the code a bit more fiddly, but it seems worth
> it. New patches attached.
Thank you for updating the patch!
- <entry>Replication slot name used by this WAL receiver</entry>
+ <entry>
+ Replication slot name used by this WAL receiver. This is only set if a
+ permanent replication slot is set using <xref
+ linkend="guc-primary-slot-name"/>. Otherwise, the WAL receiver may use
+ a temporary replication slot (determined by <xref
+ linkend="guc-wal-receiver-create-temp-slot"/>), but these are not shown
+ here.
+ </entry>
Now that the slot name is shown even if it's a temp slot the above
documentation changes needs to be changed. Other changes look good to
me.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services