[HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.

Поиск

Список

Период

Сортировка

От	Hadi Moshayedi
Тема	[HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.
Дата	21 июля 2017 г. 20:09:25
Msg-id	CA+_kT_cCew4OKqTL-ueNndEL1jWYu+3e9RdLZP-_WR1KbONzfA@mail.gmail.com обсуждение исходный текст
Ответы	Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public. (Hadi Moshayedi <hadi@citusdata.com>) Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup()public. (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Список	pgsql-hackers

Дерево обсуждения

Hello,

The attached patch moves declarations of ExplainBeginGroup()/ExplainEndGroup() from explain.c to explain.h.

This can be useful for extensions that need explain groups in their custom-scan explain output.

For example, Citus uses groups in its custom explain outputs [1]. But it achieves it by having a copy of
ExplainBeginGroup()/ExplainEndGroup() in its source code, which is not the best way.

Please review.

[1] https://github.com/citusdata/citus/blob/master/src/backend/distributed/planner/multi_explain.c

Thanks,

Hadi