Re: [patch] Column selection on SQLEditor

This doesn't seem to work as one would expect. Given a test query of
"SELECT * FROM pg_class":

- I select the relnamespace column, hit Copy, and I can paste the
results (as expected).

- I then select the relhasindex column as well. I hit Copy, and when I
paste, I only get the relhasindex values.

- I un-check relhasindex, and check relfilenode. This time when I
paste, I see both relnamespace and relhasindex in the output (as
expected).

- I then un-check the second row; this time when I paste the results,
I only get 239 rows (I expect 1298).

In short, behaviour seems quite unpredictable and somewhat broken.

 

Yep! We fixed issues with this. Note that when select-all is checked, all the other checkboxes are now unchecked: this simplifies the behavior for deselection. For example, if all the checkboxes were checked on select-all, and the user unchecks a column, they end up with all but one column checked. That seems like a weirder use case than just replacing the selection with one column.

Some additional comments; 

- I wonder if the checkbox should be vertically centered to left of
both the column name and type, rather than just the name. I suspect
that would look better.

We're going to work on some styling after this patchset. We're talking about removing the checkboxes and creating a more spreadsheet-like experience.

 

- Please don't use brand names (or trademarks etc) in test data :-)

Yep, removed!

We've attached our WIP patchset -- we will add some commits related to styling on top.