Re: [pgAdmin4][Patch]: Fixed Ascending/Descendingorder in backgrid

Поиск
Список
Период
Сортировка
От Atira Odhner
Тема Re: [pgAdmin4][Patch]: Fixed Ascending/Descendingorder in backgrid
Дата
Msg-id CA+Vc24o7_ktyc+v25o_Q-gzidAKki7QSs-CiG6tfSTOENAq0JA@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: Fixed Ascending/Descending order in backgrid  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: Fixed Ascending/Descendingorder in backgrid  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi Khushboo,

Matt and I took a look at your patch and noticed that there is code duplication between the lines you added and the preceding block of code. 

Instead of repeating the code in the else block, why not just remove the if condition?
Also, the BigNumber casting in the previous block seems unnecessary since there is no arithmetic, only comparisons happening. 

It may help to add some jasmine tests around the makeComparator method.

Tira & Matt


On Mon, Mar 27, 2017 at 8:01 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The ascending/descending order is not working in the backgrid while clicking on the headers.
If this functionality is required then please find the attached fix for the same.

Thanks,
Khushboo




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: pgAdmin4: Test result enhancement patch
Следующее
От: Sarah McAlear
Дата:
Сообщение: Re: Javascript translations