On 16 November 2012 07:20, Greg Smith <greg@2ndquadrant.com> wrote:
> Project guidelines now ask each patch submitter to review patches of the
> same number and approximate complexity as they submit. If you've submitted
> some items to the CommitFest, please look at the open list and try to find
> something you can review.
The deadline for 9.3 is looming and many patches have not yet been reviewed.
I'm sending a public reminder to all patch authors that they should
review other people's patches if they expect their own to be reviewed.
Simply put, if you don't help each other by reviewing other patches
then the inevitable result will be your patch will not be neither
reviewed nor committed.
PostgreSQL has always maintained high standards and the QA process for
all code is for it to be reviewed/discussed prior to commit, which is
known as "peer review". The PostgreSQL project is fortunate to have so
many keen developers, though for some time now there has been an
imbalance between the amount of code to review and the amount of time
available to do those reviews. I suggested that we encourage peer
review by developers, on the basis of "one patch, one review" as a way
of solving the problem. Since many/most people are submitting patches
as part of their professional job, this message needs to be passed on
to your bosses so they are able to allocate sufficient time for you to
do both development *and* peer review. Future planning needs to take
into account the time/cost of both of those tasks.
Let's bring balance to the situation through our own actions. Please
review one patch now for every one you submitted.
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services