Re: heap vacuum & cleanup locks

Поиск
Список
Период
Сортировка
От Simon Riggs
Тема Re: heap vacuum & cleanup locks
Дата
Msg-id CA+U5nMK33o5RV56TbCOC91hrqWGHsMYAgkq_PUO_icrqgVz8RQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: heap vacuum & cleanup locks  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: heap vacuum & cleanup locks  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Thu, Nov 3, 2011 at 1:26 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> I think that should be OK, but:
>
> - It looks to me like you haven't done anything about the second heap
> pass.  That should probably get a similar fix.

I was assuming this worked with Pavan's patch to remove second pass.

Not in any rush to commit this, so will wait till that is thru.

> - I think that this is going to screw up the reltuples calculation
> unless we fudge it somehow.  The number of scanned pages has already
> been incremented by the time your new code is reached.

Yeh, I'll have a look at that in more detail. Thanks for the review.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: heap vacuum & cleanup locks
Следующее
От: Dimitri Fontaine
Дата:
Сообщение: Re: removing =>(text, text) in 9.2