On 23 October 2014 00:21, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> Attached patch is latest version patch I modified above.
>> Also, I noticed I had forgotten to add the patch regarding document of
>> reindexdb.
>
> Please don't use pg_catalog in the regression test. That way we will
> need to update the expected file whenever a new catalog is added, which
> seems pointless. Maybe create a schema with a couple of tables
> specifically for this, instead.
These patches look fine to me. Don't see anybody objecting either.
Are you looking to commit them, or shall I?
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services