On 31 July 2014 15:48, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> On 07/31/2014 05:19 PM, Simon Riggs wrote:
>>
>> On 31 July 2014 14:59, Heikki Linnakangas <heikki.linnakangas@iki.fi>
>> wrote:
>>
>>> Move log_newpage and log_newpage_buffer to xlog.c.
>>
>>
>> Got a feeling this wasn't properly discussed because its unlikely
>> anybody would agree with adding more stuff to xlog.c
>
>
> Well, they certainly don't belong in heapam.c... Got a better suggestion?
I guess if we had xlog_fpi.c with RestoreBackupBlock et all, plus the
stuff you just moved it might make sense.
Just looking for ways to prune it down.
> (I bumped into this again while working on the WAL format & API changes,
> which understandably rewrites those functions again. It seemed better to do
> this refactoring separately than include it in the huge patch.)
Yeh, no problem with the refactoring itself, but I wanted to remind
you to discuss stuff.
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services