Re: Substituting Checksum Algorithm (was: Enabling Checksums)

On 30 April 2013 12:23, Ants Aasma  wrote:

>> ISTM that we also need this patch to put memory barriers in place
>> otherwise the code might be rearranged.
>
> The compiler and CPU both have to preserve correctness when
> rearranging code, so I don't think we care about it here. It might
> matter if these routine could be called concurrently by multiple
> backends for a single buffer, but in that case memory barriers won't
> be enough, we'd need full exclusion.

Certainly happy not to commit anything else...

Thanks to Ants and Andres.

--Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services