On 27 January 2014 10:40, Marti Raudsepp <marti@juffo.org> wrote:
> On Sun, Jan 26, 2014 at 11:19 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> For 9.4, we should cut down the patch so it has
>> plpgsql.warnings = none (default) | all | [individual item list]
>
>> plpgsql.warnings_as_errors = off (default) | on
>
> I hope I'm not late for the bikeshedding :)
>
> Why not have 2 similar options:
> plpgsql.warnings = none (default) | all | [individual item list]
> plpgsql.errors = none (default) | all | [individual item list]
>
> That would be cleaner, more flexible, and one less option to
> set if you just want errors and no warnings.
That would allow you to mis-set the parameters and then cause a
runtime error for something that was only a warning at compile time.
Florian's point was well made and we must come up with something that
allows warning/errors at compile time and once accepted, nothing at
run time.
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services