On Wed, Jan 4, 2012 at 1:31 PM, Stephen Frost <sfrost@snowman.net> wrote:
> Simon, all,
>
> * Simon Riggs (simon@2ndQuadrant.com) wrote:
>> (1) report all errors on a page, including errors that don't change
>> PostgreSQL data. This involves checksumming long strings of zeroes,
>> which the checksum algorithm can't tell apart from long strings of
>> ones.
>
> Do we actually know when/where it's supposed to be all zeros, and hence
> could we check for that explicitly? If we know what it's supposed to
> be, in order to be consistent with other information, I could certainly
> see value in actually checking that.
Yes, we can. Excellent suggestion, will implement.
That means we can keep the CRC calc fast as well as check the whole of
the page inbound.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services