On 20 January 2014 15:46, Stephen Frost <sfrost@snowman.net> wrote:
> So you're still looking for an 'OWNED' noise word to be added?
To clarify what the command is actually doing.
> Also, I
> did add the ability to specify types of objects (it's often that we'll
> have a "INDEXES" tablespace, so this made sense), so how about:
>
> ALTER TABLESPACE name MOVE OWNED TO name opt_nowait
The ALL seems to have value. "MOVE ALL OWNED TO" sounds better.
> ALTER TABLESPACE name MOVE TABLES OWNED TO name opt_nowait
> ALTER TABLESPACE name MOVE INDEXES OWNED TO name opt_nowait
On those two, I think the docs need to be clearer that we mean that
TABLES means tables, and yes we leave the indexes behind. Or that
INDEXES means "and we leave the tables behind. This is intended to
more easily separate tables and indexes into their own tablespaces."
or similar.
> ALTER TABLESPACE name MOVE MATERIALIZED VIEWS OWNED TO name opt_nowait
>
> Removing the 'ALL' entirely?
>
> Should there be an "OWNED BY name_list" option also, since that's how we
> use 'OWNED' elsewhere? Should the use of "OWNED" elsewhere (eg:
> REASSIGN OWNED BY) also support just 'OWNED' to mean the current role
> (I'm not entirely sure how much sense that makes, but figured I'd ask).
Maybe.
I'm not clamouring for squeezing additional goodies from you, just to
make a small change to avoid later confusion (for ALL users ;-) )
Good feature, thanks for working on it.
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services