Re: GUC for temporarily disabling event triggers

On Thu, Sep 7, 2023 at 1:57 AM Michael Paquier <michael@paquier.xyz> wrote:
> +           GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE
>
> I am a bit surprised by these two additions.  Setting this GUC at
> file-level can be useful, as is documenting it in the control file if
> it provides some control of how a statement behaves, no?

Yeah, I don't think these options should be used.

> +       Allow temporarily disabling execution of event triggers in order to
> +       troubleshoot and repair faulty event triggers. All event triggers will
> +       be disabled by setting it to <literal>true</literal>. Setting the value
> +       to <literal>false</literal> will not disable any event triggers, this
> +       is the default value. Only superusers and users with the appropriate
> +       <literal>SET</literal> privilege can change this setting.
>
> Event triggers are disabled if setting this GUC to false, while true,
> the default, allows event triggers.  The values are reversed in this
> description.

Woops.

--
Robert Haas
EDB: http://www.enterprisedb.com