On Fri, May 1, 2015 at 1:05 PM, Qingqing Zhou <zhouqq.postgres@gmail.com> wrote:
> On Thu, Apr 30, 2015 at 5:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> I think I'd have done many of these as
>>
>> + PlanState *outerPlan = outerPlanState(node);
>>
>> rather than finding assorted random places to initialize the variables.
>>
>
> Agreed. Attached patch is revision along this line. Except for a few
> that delayed assignments does not look a random kludge, I moved most
> of others together with the declaration.
I fixed several whitespace errors, reverted the permissions changes
you included, adjusted the remaining call site to be the way Tom wants
(and I think he's right), and committed this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company