On Thu, May 16, 2019 at 2:56 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> Yes. Thanks for the comment!
> Attached is the updated version of the patch.
> It adds such common rule.
I'm not sure how much value it really has to define
opt_boolean_or_string_or_numeric. It saves 1 line of code in each of
3 places, but costs 6 lines of code to have it.
Perhaps we could try to unify at a higher level. Like can we merge
vac_analyze_option_list with explain_option_list?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company