On Mon, Sep 14, 2015 at 10:54 AM, Teodor Sigaev <teodor@sigaev.ru> wrote:
>> /*
>> - * We use UNION ALL rather than UNION; this might sometimes result in
>> - * duplicate entries in the OID list, but we don't care.
>> + * this might sometimes result in duplicate entries in the OID list,
>> + * but we don't care.
>> */
>>
>> This looks totally incoherent. You've removed the thing to which the
>> word "this" referred and replaced it with nothing.
>
>
> Oops.
>
> /*
> * The loop below runs multiple SELECTs might sometimes result in
> * duplicate entries in the OID list, but we don't care.
> */
>
> looks reasonable?
Sure, that seems fine.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company