On Thu, Mar 19, 2020 at 9:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > You could make INNER_VAR -1 and so on. Then it would probably break
> > quite clearly if it's not signedness clean.
>
> I kinda like this, because it'd avoid having random large constants
> in the code.
>
> We'd have to change Var.varno and some other places from Index to
> plain int, or else invent a typedef --- but the number of places
> currently using plain int for this sort of purpose is very large,
> so probably a new typedef is not worth the hassle.
Honestly, having typedef int RangeTableIndex seems pretty appealing to
me. OK, maybe there aren't that many places, but it would make it a
lot more greppable, which seems pretty nice.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company