On Thu, Jul 7, 2022 at 8:22 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> Thanks for the reply.
>
> Yes if it is "RelFileLocator when we're talking about all the things
> that are needed to locate a relation's files on disk,". I read this as
> RelFileLocator is a kind of pointer to files. I thought RelFileNode
> as a pointer as well as the storage itself. The difference of the two
> for me could be analogized as the difference between "DropFileBuffers"
> and "DropFileNameBuffers". I think the latter is usually spelled as
> "DropBuffersByFileNames" or such.
>
> Though, I don't want to keep fighting any further if others don't feel
> it uneasy ;)
I wouldn't mind if we took "Locator" out of the name of that function
and just called it DropRelFileBuffers or DropRelationBuffers or
something. That would be shorter, and maybe more intuitive.
I wasn't quite able to understand whether your original question was
prompted by having missed the commit in question, or whether you
disagreed with it, so that's why I asked whether you had seen the
commit message.
--
Robert Haas
EDB: http://www.enterprisedb.com