Re: Why MarkBufferDirtyHint doesn't increment shared_blks_dirtied

On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> MarkBufferDirty() always increment BufferUsage counter
> (shared_blks_dirtied) for dirty blocks whenever it dirties any
> block, whereas same is not true for MarkBufferDirtyHint().
> Is there any particular reason for not incrementing
> shared_blks_dirtied in MarkBufferDirtyHint()?

Hmm, I think that's a bug, dating back to this commit:

commit 2254367435fcc4a31cc3b6d8324e33c5c30f265a
Author: Robert Haas <rhaas@postgresql.org>
Date:   Wed Feb 22 20:33:05 2012 -0500
   Make EXPLAIN (BUFFERS) track blocks dirtied, as well as those written.
   Also expose the new counters through pg_stat_statements.
   Patch by me.  Review by Fujii Masao and Greg Smith.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company