Re: [PATCH] LockAcquireExtended improvement

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: [PATCH] LockAcquireExtended improvement
Дата
Msg-id CA+TgmoaZNzNywg+jBXOYcsYbF5gdcY8+y5P5FofEEs6uyaN7_A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] LockAcquireExtended improvement  ("Jingxian Li" <aqktjcm@qq.com>)
Ответы Re: [PATCH] LockAcquireExtended improvement  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On Mon, Mar 11, 2024 at 11:11 PM Jingxian Li <aqktjcm@qq.com> wrote:
> Your version changes less code than mine by pushing the nowait flag down
> into ProcSleep(). This looks fine in general, except for a little advice,
> which I don't think there is necessary to add 'waiting' suffix to the
> process name in function WaitOnLock with dontwait being true, as follows:

That could be done, but in my opinion it's not necessary. The waiting
suffix will appear only very briefly, and probably only in relatively
rare cases. It doesn't seem worth adding code to avoid it.

--
Robert Haas
EDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Aleksander Alekseev
Дата:
Сообщение: Re: CF entries for 17 to be reviewed
Следующее
От: Xing Guo
Дата:
Сообщение: Disable LLVM bitcode generation with pgxs.mk framework.