Re: Add protransform for numeric, varbit, and temporal types

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Add protransform for numeric, varbit, and temporal types
Дата
Msg-id CA+TgmoaMSOgmgn2wTF9HTs5Oy3q2_QmF6xPj6PJ0iAnMQ=DE7g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Add protransform for numeric, varbit, and temporal types  (Noah Misch <noah@leadboat.com>)
Список pgsql-hackers
On Tue, Feb 7, 2012 at 8:45 PM, Noah Misch <noah@leadboat.com> wrote:
> On Tue, Feb 07, 2012 at 12:43:11PM -0500, Robert Haas wrote:
>> I've committed the numeric and varbit patches and will look at the
>> temporal one next.
>
> Thanks.  The comment you added to numeric_transform() has a few typos,
> "constained" -> "constrained" and "nodes" -> "notes".

Yuck, that's pretty bad.  Thanks, fixed (I hope).

> When we rebuild the table at this point, it has a small maximum tuple size.
> Therefore, we omit the toast table entirely.

Ah, OK.  The debug messages might be more clear if they mentioned
whether or not we were omitting the TOAST table, I suppose.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Progress on fast path sorting, btree index creation time
Следующее
От: Robert Haas
Дата:
Сообщение: Re: patch for implementing SPI_gettypemod()