Re: FileFallocate misbehaving on XFS

On Mon, Dec 16, 2024 at 9:12 AM Andres Freund <andres@anarazel.de> wrote:
> Personally I don't like the obfuscation of "allocate" and "zero" vs just
> naming the function names. But I guess that's just taste thing.
>
> When looking for problems it's considerably more work with bytes, because - at
> least for me - the large number is hard to compare quickly and to know how
> aggressively we extended also requires to translate to blocks.

FWIW, I think that what we report in the error should hew as closely
to the actual system call as possible. Hence, I agree with your first
complaint and would prefer to simply see the system calls named, but I
disagree with your second complaint and would prefer to see the byte
count.

--
Robert Haas
EDB: http://www.enterprisedb.com