On Thu, Jun 4, 2015 at 9:42 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> Thanks for the review.
Here's a new version. I've fixed the things Alvaro and Noah noted,
and some compiler warnings about set but unused variables.
I also tested it, and it doesn't quite work as hoped. If started on a
cluster where oldestMultiXid is incorrectly set to 1, it starts up and
indicates that the member wraparound guards are disabled. But even
after everything is fixed, they don't get enabled until after the next
full restart. I think that's because TruncateMultiXact() bails out
too early, without calling DetermineSafeOldestOffset.
My attempt at a quick fix for that problem didn't work out, so I'm
posting this version for now to facilitate further review and testing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company