On Tue, Jul 26, 2011 at 9:21 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> On Tue, Jul 26, 2011 at 9:53 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Mon, Jul 25, 2011 at 10:29 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
>> I think this is basically the right approach but I found what you did
>> here a bit wordy, so I simplified it, committed it, and back-patched
>> to 9.0 with suitable adjustment. Hopefully I didn't simplify it into
>> a form you don't like.
>
> That looks fine. Minor grammar quibble about:
>
> + When commenting on a column,
> + <replaceable class="parameter">relation_name</replaceable> must refer
> + to a table, view, composite types, or foreign table.
>
> "types" should probably be the singular "type".
Woops. That was dumb. Fixed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company