Re: Unlogged tables and BufferSync()

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Unlogged tables and BufferSync()
Дата
Msg-id CA+TgmoZnjXtsCn7vwFr21JrYAgSVh-pimFW0CsSAVSO7HxaiVA@mail.gmail.com
обсуждение исходный текст
Ответ на Unlogged tables and BufferSync()  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Список pgsql-hackers
On Fri, Jan 6, 2012 at 7:52 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> In BufferSync(), we have this:
>
>>        /*
>>         * Unless this is a shutdown checkpoint, we write only permanent,
>> dirty
>>         * buffers.  But at shutdown time, we write all dirty buffers.
>>         */
>>        if (!(flags & CHECKPOINT_IS_SHUTDOWN))
>>                flags |= BM_PERMANENT;
>
>
> That seems bogus to me. We're mixing CHECKPOINT_* flags and buffer BM_*
> flags in the same variable. Furthermore, we only use that flags variable to
> pass it down to CheckpointWriteDelay(), which only pays attention to
> CHECKPOINT_IMMEDIATE flag. The intention was probably to do "mask |=
> BM_PERMANENT" ?

Ouch.  Yeah, that's a bug, will fix.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Unlogged tables and BufferSync()
Следующее
От: Michael Beattie
Дата:
Сообщение: Re: FATAL: bogus data in lock file "postmaster.pid": ""