Re: Re: [COMMITTERS] pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.

On Fri, Jul 8, 2011 at 10:57 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> So if MaxTransactionId+1 overflows to zero, OLDSERXID_MAX_PAGE becomes -1.
> Or a very high value, if the result of that is unsigned, as at least MSVC
> seems to interpret it given the other warning I got. If it's interpreted as
> a large unsigned value, then the SLRU_PAGES_PER_SEGMENT * 0x10000 - 1 value
> wins. That's what what we had prior to this patch, in beta2, so we're back
> to square one. If it's interpreted as signed -1, then bad things will happen
> as soon as the SLRU is used.

Should we, then, consider rewrapping beta3?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company