Re: Fix comment in ATExecValidateConstraint

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Fix comment in ATExecValidateConstraint
Дата
Msg-id CA+TgmoZXugh77M1tSVYZgSOE9U3TtzvKaCQYGwWYct-K0f0oJQ@mail.gmail.com
обсуждение исходный текст
Ответ на Fix comment in ATExecValidateConstraint  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Ответы Re: Fix comment in ATExecValidateConstraint  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Список pgsql-hackers
On Mon, Jul 25, 2016 at 4:18 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> The comment seems to have been copied from ATExecAddColumn, which says:
>
>  /*
>   * If we are told not to recurse, there had better not be any
> - * child tables; else the addition would put them out of step.
>
> For ATExecValidateConstraint, it should say something like:
>
> + * child tables; else validating the constraint would put them
> + * out of step.
>
> Attached patch fixes it.

I agree that the current comment is wrong, but what does "out of step"
actually mean here, anyway?  I think this isn't very clear.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: Why we lost Uber as a user
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: sslmode=require fallback