Re: Incorrect comment in get_partition_dispatch_recurse

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Incorrect comment in get_partition_dispatch_recurse
Дата
Msg-id CA+TgmoZLchgm2XoVBjTP+ZLtVPW5i6jk+AfwBKGdWu4Uxvfn1g@mail.gmail.com
обсуждение исходный текст
Ответ на Incorrect comment in get_partition_dispatch_recurse  (David Rowley <david.rowley@2ndquadrant.com>)
Ответы Re: Incorrect comment in get_partition_dispatch_recurse  (David Rowley <david.rowley@2ndquadrant.com>)
Список pgsql-hackers
On Mon, May 14, 2018 at 12:57 AM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> I noticed that a comment in get_partition_dispatch_recurse claims that:
>
> "it contains the
> * leaf partition's position in the global list *leaf_part_oids minus 1"
>
> The "minus 1" part is incorrect. It simply just stores the 0-based
> index of the item in the list. I was going to fix it by removing just
> that part, but instead, I ended up rewriting the whole thing.

I think that's clearer.  Committed with a few tweaks that are
hopefully improvements.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: index scan over composite type
Следующее
От: Robert Haas
Дата:
Сообщение: Re: log_min_messages shows debug instead of debug2