Re: [HACKERS] foreign partition DDL regression tests

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: [HACKERS] foreign partition DDL regression tests
Дата
Msg-id CA+TgmoZ5nTVZhhAOubtap_Yrf+DELU__owXWROkt_7GO-somWg@mail.gmail.com
обсуждение исходный текст
Ответ на [HACKERS] foreign partition DDL regression tests  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Ответы Re: [HACKERS] foreign partition DDL regression tests  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Список pgsql-hackers
On Tue, Feb 21, 2017 at 8:40 PM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> Ashutosh Bapat pointed out [0] that regression tests are missing for the
> foreign partition DDL commands.  Attached patch takes care of that.

Committed.

I didn't do anything about Ashutosh's comment that we could use ALTER
FOREIGN TABLE rather than ALTER TABLE someplace; that didn't seem
critical.

Also, the names of the objects in this test are kinda generic (pt2 et.
al.) but they match the existing names in the same file (pt1, foo).
If we're going to start differentiating those a little better, we
should probably change them all, and as a separate commit.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dilip Kumar
Дата:
Сообщение: Re: [HACKERS] Parallel bitmap heap scan
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] patch: function xmltable