Re: Eager aggregation, take 3

On Tue, Oct 7, 2025 at 6:57 AM Richard Guo <guofenglinux@gmail.com> wrote:
> > 10. I don't think this comment quite makes sense:
> >
> >  * "apply_at" tracks the lowest join level at which partial aggregation is
> >  * applied.
> >
> > maybe "minimum set of rels to join before partial aggregation can be applied"?
> I've updated the comment for apply_at to clarify that it refers to the
> relids at which partial aggregation is applied.
>
> I've also updated the comments within RelAggInfo to use one-line
> style.
>
> I retained the name of this field though.

For what it's worth, I also don't like that field name. I'm not sure
what to propose instead, but I don't think apply_at is very clear.

--
Robert Haas
EDB: http://www.enterprisedb.com