On Wed, Jan 18, 2017 at 3:43 PM, Stephen Frost <sfrost@snowman.net> wrote:
> * Robert Haas (robertmhaas@gmail.com) wrote:
>> On Tue, Jan 17, 2017 at 5:31 PM, Stephen Frost <sfrost@snowman.net> wrote:
>> > If I'm understanding your concern correctly, you're worried about the
>> > case of a cold standby where the database is only replaying WAL but not
>> > configured to come up as a hot standby and therefore PQping() won't ever
>> > succeed?
>>
>> I think we've changed the defaults to make things better for an
>> attended startup and worse for an unattended startup. But I think
>> most PostgreSQL startups are probably unattended.
>
> I don't understand how it's worse for an unattended startup to tell the
> init system that the database is now up and running when, in fact, it
> isn't.
>
> If that isn't what you meant, then it would be really helpful if you
> could explain a bit more what you see as being "worse" with this change
> for unattended startup.
This seems clear as day to me, so I'm not sure what to explain.
Anybody who has got a script that runs pg_ctl unattended mode likely
now has to go update that script to add --no-wait. If they don't,
their script may hang for whatever the timeout is (currently 60
seconds, and it sounds like Peter wants to change that to infiniity).
If they have been wanting their script to hang all along, as you seem
to be saying, then they'll be happy that it now does. If, on the
other hand, they don't want that, then they'll be sad.
In short, I bet we will get multiple reports of people getting hosed
by this change.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company