Re: Move unused buffers to freelist

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Move unused buffers to freelist
Дата
Msg-id CA+TgmoYhfcANR4ci01Gtd8YFzca=VTW9dVn9TY4RM+OdYqCPPw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Move unused buffers to freelist  (Greg Smith <greg@2ndQuadrant.com>)
Ответы Re: Move unused buffers to freelist
Список pgsql-hackers
>> Instead, I suggest modifying BgBufferSync, specifically this part right
>> here:
>>
>>         else if (buffer_state & BUF_REUSABLE)
>>             reusable_buffers++;
>>
>> What I would suggest is that if the BUF_REUSABLE flag is set here, use
>> that as the trigger to do StrategyMoveBufferToFreeListEnd().
>
> I think at this point also we need to lock buffer header to check refcount
> and usage_count before moving to freelist, or do you think it is not
> required?

If BUF_REUSABLE is set, that means we just did exactly what you're
saying.  Why do it twice?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: preserving forensic information when we freeze
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: ASYNC Privileges proposal