Re: [HACKERS] 64-bit queryId?

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: [HACKERS] 64-bit queryId?
Дата
Msg-id CA+TgmoYYXX=7WiMyzExTxHDUwVJeU9ByN_wRUa8jMrc6Cbjb-w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] 64-bit queryId?  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: [HACKERS] 64-bit queryId?  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
On Tue, Oct 3, 2017 at 9:34 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> +/* Write an unsigned integer field (anything written with UINT64_FORMAT) */
> +#define WRITE_UINT64_FIELD(fldname) \
> +   appendStringInfo(str, " :" CppAsString(fldname) " " UINT64_FORMAT, \
> +                    node->fldname)
> Correct call here.

I'm sorry, but I don't understand this comment.

>  {
> -   return hash_any((const unsigned char *) str, len);
> +   return hash_any_extended((const unsigned char *) str, len, 0);
>  }
> [...]
> -           uint32      start_hash = hash_any(jumble, JUMBLE_SIZE);
> +           uint64      start_hash = hash_any_extended(jumble, JUMBLE_SIZE, 0);
> Missing two DatumGetUInt64() perhaps? HEAD looks wrong to me as well.

Ah, yes, you're right.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Badrul Chowdhury
Дата:
Сообщение: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - versioncompatibility)
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?