On Tue, Dec 17, 2019 at 3:48 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Oh, scratch that --- looking closer, I see that the only two use-cases in
> the patched code are via before_shmem_exit and PG_ENSURE_ERROR_CLEANUP,
> and both of those require a function with the signature of an on_exit
> callback.
Yeah, that's why I was surprised that you wanted shim functions.
> So there's no need for a separate wrapper because this isn't
> going to be called any other way. I still recommend amending the
> comment to explain why it has this signature, though.
Done, and committed.
Thanks,
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company