On Thu, Jan 30, 2014 at 11:06 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jan 30, 2014 at 03:36:48PM -0500, Bruce Momjian wrote:
>> On Thu, Jan 30, 2014 at 03:32:27PM -0500, Robert Haas wrote:
>> > Or this:
>> >
>> > - mp_int_copy(a, b); /* ok: 0 <= r < b */
>> > - mp_int_copy(&q, a); /* ok: q <= a */
>> > + mp_int_copy(a, b); /* ok: 0 <= r < b */
>> > + mp_int_copy(&q, a); /* ok: q <= a */
>> >
>> > I do agree with you some of the changes-after-periods look like
>> > improvements; what I meant to say is that there is an awful lot of
>> > churn in this patch that is unrelated to that particular point.
>>
>> Let me work on a entab patch that does replacements in comments only
>> after periods and post the results. I should be done in an hour.
>
> OK, eight hours later, I have the results for only removing tabs after
> periods in comments:
>
> http://momjian.us/expire/entab_comment.v2.cdiff
> http://momjian.us/expire/entab_comment.v2.pdiff
> http://momjian.us/expire/entab_comment.v2.udiff
>
> The diff line counts are:
>
> 64356 entab_comment.v2.cdiff
> 17327 entab_comment.v2.pdiff
> 35453 entab_comment.v2.udiff
>
> It represents 3903 lines changed.
That looks loads better.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company