Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44)

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44)
Дата
Msg-id CA+TgmoYSWhwq3RXbmPA0a6cMMHZ=9-EN5mMH6TSkxx0QH3gt6A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44)  (Peter Geoghegan <pg@heroku.com>)
Список pgsql-hackers
On Wed, Mar 4, 2015 at 1:55 PM, Peter Geoghegan <pg@heroku.com> wrote:
> On Wed, Mar 4, 2015 at 8:26 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> I think we should commit my patch, and if a future patch needs
>> sortKeys set in more places, it can make that change itself.  There's
>> no reason why it's needed with the code as it is today, and no reason
>> to let bits of future changes leak into a bug-fix patch.
>
> It's not as if I feel strongly about it. It's trivial to change the
> code to make the comment true, rather than change the comment to make
> the code true, and we need to do so anyway. I defer to you.

I did it my way.  Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: Object files generated by ecpg test suite not ignored on Windows
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Parallel Seq Scan