Re: Jsonb: jbvBinary usage in the convertJsonbValue?

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Jsonb: jbvBinary usage in the convertJsonbValue?
Дата
Msg-id CA+TgmoYJV5h+EhTvqC0LcbXrg0VgHaZVLwWaT2CBDO0Dqt-PoA@mail.gmail.com
обсуждение исходный текст
Ответ на Jsonb: jbvBinary usage in the convertJsonbValue?  (Dmitry Dolgov <9erthalion6@gmail.com>)
Ответы Re: Jsonb: jbvBinary usage in the convertJsonbValue?
Список pgsql-hackers
On Thu, May 29, 2014 at 7:34 AM, Dmitry Dolgov <9erthalion6@gmail.com> wrote:
> I'm little confused by the convertJsonbValue functon at jsonb_utils.c
> Maybe I misunderstood something, so I need help =)
>
>>>> if (IsAJsonbScalar(val) || val->type == jbvBinary)
>>>>     convertJsonbScalar(buffer, header, val);
>
> As I can see, the convertJsonbScalar function is used for scalar and binary
> jsonb values. But this function doesn't handle the jbvBinary type.

There definitely seems to be an oversight here of some kind.  Either
convertJsonbValue() shouldn't be calling convertJsonbScalar() with an
object of type jbvBinary, or convertJsonbScalar() should know how to
handle that case.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: Re: pg_stat directory and pg_stat_statements
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Re-create dependent views on ALTER TABLE ALTER COLUMN ... TYPE?