Re: CreateEventTrigStmt copy fix

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: CreateEventTrigStmt copy fix
Дата
Msg-id CA+TgmoYFWV8U00bO3Zhsr2kJZY=jZmYdHVqagDNztz+ogvrqpg@mail.gmail.com
обсуждение исходный текст
Ответ на CreateEventTrigStmt copy fix  (Petr Jelinek <petr@2ndquadrant.com>)
Список pgsql-hackers
On Fri, Sep 19, 2014 at 12:09 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
> I was trying to create event trigger inside DO statement inside an extension
> SQL script and noticed that the new event trigger has empty evtevent field.
> After some tinkering with gdb I found out that the memory context switches
> sometimes clear the eventname in CreateEventTrigStmt struct. The reason for
> this is that _copyCreateEventTrigStmt uses COPY_SCALAR_FIELD on eventname
> instead of COPY_STRING_FIELD.
>
> Attached patch fixes this and also the same issue in
> _equalCreateEventTrigStmt.
>
> This should be back-patched to 9.3 where event triggers were introduced.

Done, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)
Следующее
От: Josh Berkus
Дата:
Сообщение: Re: jsonb format is pessimal for toast compression