Re: Fixed redundant i18n strings in json

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: Fixed redundant i18n strings in json
Дата
Msg-id CA+TgmoY6gSoNtrRX3_yRQgVa639PVBUmY+ygYdUL9X7DgHcY4A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fixed redundant i18n strings in json  (Daniele Varrazzo <daniele.varrazzo@gmail.com>)
Ответы Re: Fixed redundant i18n strings in json  (Jeff Janes <jeff.janes@gmail.com>)
Re: Fixed redundant i18n strings in json  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:
> I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
> "argument 1: something is wrong": the string is likely to end up in
> sentences with other colons so I'd rather use "something is wrong at
> argument 1".
>
> Is the patch attached better?

Looks OK to me.  I thought someone else might comment, but since no
one has, committed.

(As a note for the future, you forgot to update the regression test
outputs; I took care of that before committing.)

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Spinlocks and compiler/memory barriers
Следующее
От: Jerry Sievers
Дата:
Сообщение: Append to a GUC parameter ?