On Thu, Mar 13, 2014 at 9:07 PM, Josh Berkus <josh@agliodbs.com> wrote:
> On 03/13/2014 05:28 PM, Robert Haas wrote:
>> Well we may have kind of hosed ourselves, because the in-memory data
>> structures that represent the data structure have an in_use flag that
>> indicates whether the structure is allocated at all, and then an
>> active flag that indicates whether some backend is using it. I never
>> liked that naming much. Maybe we should go through and let in_use ->
>> allocated and active -> in_use.
>
> Wait, which one of those does pg_drop_replication_slot() care about?
Well... the slots that aren't in_use can't be dropped because they
don't exist in the first place. The ones that aren't active can't be
dropped because somebody else is using them. So both, sorta, I guess?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company