Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.

On Tue, Dec 19, 2023 at 8:01 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> > Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
> >
> > This makes it possible for the code to be easily reused by other
> > client-side tools, and/or by the server.
> >
> > Patch by me. Review of this patch in particular by at least Peter
> > Eisentraut; reviewers for the patch series in general include Dilip
> > Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.
>
> Worth noting that this has forgotten to update @pgcommonallfiles in
> Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
> Or you counted on me here, relying on the scripts to be gone?  ;p

To be honest, I counted on CI to tell me whether it still builds everywhere.

--
Robert Haas
EDB: http://www.enterprisedb.com