Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explainplan as JPEG/SVG format

Hi Hackers

I didn't find the solution to show embedded SVG in Internet Explorer, so I have disabled the "Download" button for Internet Explorer. Added new function to get the browser name and version.

Attached is the modified patch, please review it. 

On Mon, Dec 3, 2018 at 6:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Hackers, 

I am currently working on Feature 3589 "Allow user to save/download Explain plan as JPEG/SVG format."  I have added one download button to the toolbar in "Explain" tab, when clicked it will download the explain plan as a SVG file.

To add this feature I'll have to modify the logic, so instead of providing relative path of each plan (svg image), I have embedded the binary data which is required to download the Explain plan.

I have tested it on following:

• Chrome (Working Fine)
• FireFox (Working Fine)
  
• Microsoft Edge (Working Fine)
• Safari 10.1 and above. 'Download' attribute support is added in 10.1 https://developer.apple.com/library/archive/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html
• Internet Explorer (Images are not rendered, shown X icon.). Please refer attached image.

Attached is the working patch for the above except Internet Explorer. I have tried a lot to figure out the solution, but unable to fix the issue. Need help/suggestions how to fix the issue on Internet Explorer. 

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246